Add fractional seconds support for direct input #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
allowinput_fractional_seconds
branch
from
7be6ac1
to
c751013
Compare
|
Hello and thank you for this improvement! Any idea when this will be merged? The use of Flatpickr in our project will be made possible only after fractional second support has been added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds fractional seconds support for direct input with nanosecond resolution.
The implementation is inspired by #2870 but:
formatSecondsPrecisionoption, any fixed digits are supported, -1 can be used for dynamic lengthallowInput(direct input modification) support is well implemented and tested for typical usecases. This PR does not aim to provide UI for setting fractional seconds via flatpickr popup in order to focus on the flatpickr internal implementation. Once this PR is merged, the UI can be easily added.Related with:
/cc @Aditya-ds-1806 @williamdes @chmln
Sponsored by my own company.