Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #5751

Closed
wants to merge 10 commits into from
Closed

Conversation

fabianhjr
Copy link
Contributor

@fabianhjr fabianhjr commented Apr 20, 2023

Tested locally via ./gradlew check

Security/CVEs of direct dependencies:

Scalatest upgrade required a a small rename/import change of

import org.scalatest.FunSuite to import org.scalatest.funsuite.AnyFunSuite

as per https://www.scalatest.org/release_notes/3.1.0

@magnus-madsen
Copy link
Member

Thanks-- not sure if we can upgrade Scala just yet because of #4916

@magnus-madsen
Copy link
Member

How long does gradlew clean jar take on master versus with your PR on your machine?

@fabianhjr
Copy link
Contributor Author

About same time around 60s

@magnus-madsen
Copy link
Member

Is that because the Scala version is not touched?

@fabianhjr
Copy link
Contributor Author

The scala version remained at 2.13.5 yes.

I could include the dependeny tree on the description.

@magnus-madsen
Copy link
Member

In any case, we are usually handle upgrades much more "one at a time" to prevent regressions.

I think it would be sensible to break this PR into a few smaller ones that can be merged on at time:

  • One for Guava.
  • One for Java WebSocket.
  • One for ScalaTest with the changes.

@magnus-madsen
Copy link
Member

We usually do small changes and then look arewefast.flix.dev and wait for our users to report back.

@fabianhjr
Copy link
Contributor Author

Will open separate merge requests and leave this one as a meta/draft one.

@fabianhjr fabianhjr marked this pull request as draft April 20, 2023 14:36
@magnus-madsen
Copy link
Member

Will open separate merge requests and leave this one as a meta/draft one.

Sounds good, but don't do them all. Let us just focus on Gradle, ScalaTest, and the ones with CVEs.

Also I will have to merge them at 1 per hour due to arewefast.

@magnus-madsen
Copy link
Member

Superseded by other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants