Fix appveyor ci for round3 #2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because Windows does not permit to remove files which are used in another process. Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
In Winsock, linger related struct's menber types are not `int` but `u_short` (unsigned short). `linger_timeout` also should be set up when linger_timeout > 0. Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
cosmo0920
force-pushed
the
fix-appveyor-ci-for-round3
branch
from
14d9485
to
7d16531
Compare
ganmacs
reviewed
Mar 6, 2020
Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
cosmo0920
force-pushed
the
fix-appveyor-ci-for-round3
branch
from
73a2322
to
b55e610
Compare
|
I'll merge this PR after finishing CIs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Related to #2854.
linger_timeouthandling on WindowsWhat this PR does / why we need it:
We should take care of AppVeyor CI result.
Docs Changes:
No needed.
Release Note:
None.