Fix appveyor ci for round3

lib/fluent/plugin_helper/socket_option.rb

@@ -21,6 +21,8 @@
 module Fluent
   module PluginHelper
     module SocketOption
+      # ref: https://docs.microsoft.com/en-us/windows/win32/api/winsock/ns-winsock-linger
+      FORMAT_STRUCT_LINGER_WINDOWS  = 'S!S!' # { u_short l_onoff; u_short l_linger; }
       FORMAT_STRUCT_LINGER  = 'I!I!' # { int l_onoff; int l_linger; }
       FORMAT_STRUCT_TIMEVAL = 'L!L!' # { time_t tv_sec; suseconds_t tv_usec; }
 
@@ -49,9 +51,25 @@ def socket_option_set(sock, resolve_name: nil, nonblock: false, linger_timeout:
         if nonblock
           sock.fcntl(Fcntl::F_SETFL, Fcntl::O_NONBLOCK)
         end
-        if linger_timeout
+        if Fluent.windows?
+          # To prevent closing socket forcibly on Windows,
+          # this options shouldn't be set up when linger_timeout equals to 0 (including nil).
+          # This unintended behavior always ocurrs on Windows when linger_timeout.to_i == 0.
+          # This unintented behavior causes "Errno::ECONNRESET: An existing connection was forcibly
+          # closed by the remote host." on Windows.
+          if linger_timeout.to_i > 0
+            if linger_timeout >= 2**16
+              log.warn "maximum linger_timeout is 65535(2^16 - 1). Set to 65535 forcibly."
+              linger_timeout = 2**16 - 1
+            end
+            optval = [1, linger_timeout.to_i].pack(FORMAT_STRUCT_LINGER_WINDOWS)
+            socket_option_set_one(sock, :SO_LINGER, optval)
+          end
+        else
+          if linger_timeout
           optval = [1, linger_timeout.to_i].pack(FORMAT_STRUCT_LINGER)
           socket_option_set_one(sock, :SO_LINGER, optval)
+          end
         end
         if recv_timeout
           optval = [recv_timeout.to_i, 0].pack(FORMAT_STRUCT_TIMEVAL)

test/plugin/test_buf_file.rb

@@ -1062,7 +1062,9 @@ def write_metadata(path, chunk_id, metadata, size, ctime, mtime)
       if @bufdir
         Dir.glob(File.join(@bufdir, '*')).each do |path|
           next if ['.', '..'].include?(File.basename(path))
-          File.delete(path)
+          # Windows does not permit to delete files which are used in another process.
+          # Just ignore for removing failure.
+          File.delete(path) rescue nil
         end
       end
     end