Remove unnecessary timeout to fix unstable test #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
approved these changes
Apr 13, 2020
if timeout is given, breaking condition is set. if breaking condition is positive, the it passed and without errors. So no need to timeout. https://github.com/fluent/fluentd/blob/a8b6d6ff4aa83bb0f7c8aa54f3367018383236d6/lib/fluent/test/driver/base.rb#L81 https://github.com/fluent/fluentd/blob/a8b6d6ff4aa83bb0f7c8aa54f3367018383236d6/lib/fluent/test/driver/base.rb#L215 Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
ganmacs
force-pushed
the
remove-unnecessary-timeout
branch
from
8e63bf6
to
e063f89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fix https://travis-ci.org/github/fluent/fluentd/jobs/674236542#L752
What this PR does / why we need it:
if timeout is given, the breaking condition is set.
fluentd/lib/fluent/test/driver/base.rb
Line 81 in a8b6d6f
if breaking condition is true, it passed without errors. So timeout must be removed.
fluentd/lib/fluent/test/driver/base.rb
Line 215 in a8b6d6f
Docs Changes:
no need
Release Note:
same as title