Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary timeout to fix unstable test #2946

Merged
merged 1 commit into from
Apr 13, 2020

Commits on Apr 13, 2020

  1. test: Remove unnecessary timeout

    if timeout is given, breaking condition is set. if breaking condition
    is positive, the it passed and without errors. So no need to timeout.
    
    https://github.com/fluent/fluentd/blob/a8b6d6ff4aa83bb0f7c8aa54f3367018383236d6/lib/fluent/test/driver/base.rb#L81
    https://github.com/fluent/fluentd/blob/a8b6d6ff4aa83bb0f7c8aa54f3367018383236d6/lib/fluent/test/driver/base.rb#L215
    
    Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    ganmacs committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    e063f89 View commit details
    Browse the repository at this point in the history