formatter_ltsv: suppress delimiters in output #3288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace tabs with spaces before writing them to the output, to prevent creating malformed LTSV files. Also add test cases to verify this behaviour. Signed-off-by: Mike Playle <mike@mythik.co.uk>
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
ashie
changed the title
cosmo0920
approved these changes
Mar 9, 2021
|
Thanks @MikePlayle! |
ashie
added a commit
to ashie/fluentd
that referenced
this pull request
Mar 9, 2021
Line breaks should be "\r\n". Signed-off-by: Takuro Ashie <ashie@clear-code.com>
cosmo0920
added a commit
that referenced
this pull request
Mar 9, 2021
Fix some failed tests of #3288 on Windows
ashie
added a commit
to ashie/fluentd-docs-gitbook
that referenced
this pull request
Mar 17, 2021
It's introduced by fluent/fluentd#3288 Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Revise #1666
What this PR does / why we need it:
formatter_ltsv creates malformed LTSV files when values include tabs.
This PR prevent it by replacing tabs with spaces.
Docs Changes:
replacementshould be added to https://docs.fluentd.org/parser/ltsvRelease Note:
Same with the title