[in_app_purchase_storekit] migrate main plugin class to swift in preperation to storekit 2 #6561

LouiseHsu · 2024-04-17T21:43:01Z

Part of flutter/flutter#119106

This PR migrates the main InAppPurchasePlugin.m class to swift.

Pre-launch Checklist

packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/in_app_purchase_storekit.h

LouiseHsu · 2024-04-18T19:49:38Z

packages/in_app_purchase/in_app_purchase_storekit/pigeons/messages.dart

@@ -238,7 +238,7 @@ abstract class InAppPurchaseAPI {
  SKProductsResponseMessage startProductRequest(
      List<String> productIdentifiers);

-  void finishTransaction(Map<String, String?> finishMap);
+  void finishTransaction(Map<String, Object?> finishMap);


Even though the intended type here should be a nullable String, when pigeon generates obj C code, it is generated as type NSString. NSString is nullable in objective c, but when Xcode generates the corresponding swift method signature, it converts into a String, not a String?. NSString also cannot be annoted with _Nullable as it is a generic.

im confused. why is NSString generic?

Sorry, its not generic, but you can't specify a type inside a NSDictionary to be nullable. (i dont think)
Specifically here -

packages/packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/messages.g.h

Line 268 in 74de10a

- (void)finishTransactionFinishMap:(NSDictionary<NSString *, id> *)finishMap

What I really want is for this line in swift

packages/packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/InAppPurchasePlugin.swift

Line 227 in 74de10a

_ finishMap: [String: Any], error: AutoreleasingUnsafeMutablePointer<FlutterError?>

To be finishMap: [String: String?]. But the automatic conversion turns all NSStrings as String and not String?. And because I can't specify the NSString as extra nullable, I have to make it Object? (in pigeon) so it gets generated into id in objc, which then will turn into Any, and thus allow for nullability
Not sure if that makes sense lol

Using Any to represent an optional can be error-prone.
Why do you want [String:String?]? Is there any issue with using [String:String]?

Not sure how pendingTransactions is related to the dictionary type. Can you explain how using [String:String] type would fail to work here?

Yea I meant the comments
Im not understanding the question i think? finishMap should be [String:String?] because finishMap["transactionIdentifier"] should be allowed to be null.

If it's just [String:String] then finishMap["transactionIdentifier"] wouldn't be allowed to be null, right?
But if finishMap["transactionIdentifier"] is null and a transaction in pendingTransactions also has a null transactionIdentifier then that would also be a valid transaction. If we had [String:String] then we couldn't check that?

packages/packages/in_app_purchase/in_app_purchase_storekit/lib/src/store_kit_wrappers/sk_payment_transaction_wrappers.dart

Line 218 in 871a24b

Map<String, String?> toFinishMap() => <String, String?>{

You can see on the dart side that the finishMap arg it gets called with has [String:String?] as well - I genuinely do not think it would be correct to make it [String:String]. Once this gets converted to using Swift pigeon, I can change it from String:Any to String:String?, so this should be temporary

finishMap should be [String:String?] because finishMap["transactionIdentifier"] should be allowed to be null.
If it's just [String:String] then finishMap["transactionIdentifier"] wouldn't be allowed to be null, right?

Not really. dict[key] always returns optional. If type of finishMap is [String:String], then the type of finishMap["transactionIdentifier"] would be String?.

If you use [String:String?] as the type, then finishMap["transactionIdentifier"] would be String?? (double optional).

LouiseHsu · 2024-04-18T19:50:31Z

packages/in_app_purchase/in_app_purchase_storekit/example/shared/RunnerTests/Stubs.m

@@ -144,28 +144,6 @@ - (instancetype)initWithMap:(NSDictionary *)map {

 @end

-@interface InAppPurchasePluginStub ()


This plugin stub needed to be converted to swift as you cannot subclass a swift class in objective C.

hellohuanlin · 2024-04-19T19:11:20Z

Could you run formatter first so it's easier for review?

hellohuanlin

I briefly looked at the code and did not look into the details. I have to stop early as it's getting long, and there are enough feedback already.

packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/InAppPurchasePlugin.swift

hellohuanlin · 2024-04-24T19:25:53Z

packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/InAppPurchasePlugin.swift

+
+  public func handleTransactionsRemoved(_ transactions: [SKPaymentTransaction]) {
+    var maps: [[AnyHashable: Any]] = []
+    for transaction in transactions {


hellohuanlin · 2024-04-24T19:27:13Z

packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/InAppPurchasePlugin.swift

+    return value is NSNull ? nil : value
+  }
+
+  func getRefreshReceiptRequest(properties: [String: Any]?) -> SKReceiptRefreshRequest {


are these helpers only used inside this file? should use private if that's the case.

these need to be not private so they can be overriden for testing purposes
Like here:

packages/packages/in_app_purchase/in_app_purchase_storekit/example/ios/RunnerTests/SwiftStubs.swift

Line 11 in 74de10a

override func getProductRequest(withIdentifiers productIdentifiers: Set<String>)

packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/in_app_purchase_storekit.h

hellohuanlin · 2024-04-24T19:28:42Z

..._app_purchase/in_app_purchase_storekit/example/ios/RunnerTests/RunnerTests-Bridging-Header.h

+//
+
+#import "Stubs.h"
+#import "Stubs.m"


why is it importing the .m file?

hellohuanlin · 2024-04-24T19:31:28Z

packages/in_app_purchase/in_app_purchase_storekit/pigeons/messages.dart

@@ -238,7 +238,7 @@ abstract class InAppPurchaseAPI {
  SKProductsResponseMessage startProductRequest(
      List<String> productIdentifiers);

-  void finishTransaction(Map<String, String?> finishMap);
+  void finishTransaction(Map<String, Object?> finishMap);


im confused. why is NSString generic?

jmagman · 2024-04-30T22:36:54Z

SwiftGeneratePch normal arm64 Compiling\ bridging\ header (in target 'RunnerTests' from project 'Runner')
    cd /Volumes/Work/s/w/ir/x/w/packages/packages/in_app_purchase/in_app_purchase_storekit/example/macos
    builtin-swiftTaskExecution -- /Volumes/Work/s/w/ir/cache/osx_sdk/xcode_15a240d/XCode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-frontend -frontend -target arm64-apple-macos10.15 -Xllvm -aarch64-use-tbi -enable-objc-interop -stack-check -sdk /Volumes/Work/s/w/ir/cache/osx_sdk/xcode_15a240d/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk -I /Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Products/Debug -I /Volumes/Work/s/w/ir/cache/osx_sdk/xcode_15a240d/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/lib -F /Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Products/Debug -F /Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Products/Debug/in_app_purchase_storekit -F /Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Products/Debug/shared_preferences_foundation -F /Volumes/Work/s/w/ir/cache/osx_sdk/xcode_15a240d/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks -F /Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Products/Debug/OCMock -F /Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Products/Debug/in_app_purchase_storekit -F /Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Products/Debug/shared_preferences_foundation -no-color-diagnostics -enable-testing -g -module-cache-path /Users/chrome-bot/Library/Developer/Xcode/DerivedData/ModuleCache.noindex -swift-version 5 -enforce-exclusivity\=checked -Onone -D DEBUG -D COCOAPODS -D COCOAPODS -serialize-debugging-options -const-gather-protocols-file /Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Intermediates.noindex/Runner.build/Debug/RunnerTests.build/Objects-normal/arm64/RunnerTests_const_extract_protocols.json -enable-bare-slash-regex -empty-abi-descriptor -validate-clang-modules-once -clang-build-session-file /Users/chrome-bot/Library/Developer/Xcode/DerivedData/ModuleCache.noindex/Session.modulevalidation -Xcc -working-directory -Xcc /Volumes/Work/s/w/ir/x/w/packages/packages/in_app_purchase/in_app_purchase_storekit/example/macos -resource-dir /Volumes/Work/s/w/ir/cache/osx_sdk/xcode_15a240d/XCode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift -enable-anonymous-context-mangled-names -Xcc -fmodule-map-file\=/Volumes/Work/s/w/ir/x/w/packages/packages/in_app_purchase/in_app_purchase_storekit/example/macos/Pods/Headers/Public/in_app_purchase_storekit/in_app_purchase_storekit.modulemap -Xcc -fmodule-map-file\=/Volumes/Work/s/w/ir/x/w/packages/packages/in_app_purchase/in_app_purchase_storekit/example/macos/Pods/Headers/Public/integration_test/integration_test.modulemap -Xcc -fmodule-map-file\=/Volumes/Work/s/w/ir/x/w/packages/packages/in_app_purchase/in_app_purchase_storekit/example/macos/Pods/Headers/Public/shared_preferences_macos/shared_preferences_macos.modulemap -Xcc -ivfsstatcache -Xcc /Users/chrome-bot/Library/Developer/Xcode/DerivedData/SDKStatCaches.noindex/macosx14.0-23A334-edcf116c3e76c79d4aee70e3f10029bc.sdkstatcache -Xcc -I/Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Intermediates.noindex/Runner.build/Debug/RunnerTests.build/swift-overrides.hmap -Xcc -iquote -Xcc /Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Intermediates.noindex/Runner.build/Debug/RunnerTests.build/RunnerTests-generated-files.hmap -Xcc -I/Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Intermediates.noindex/Runner.build/Debug/RunnerTests.build/RunnerTests-own-target-headers.hmap -Xcc -I/Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Intermediates.noindex/Runner.build/Debug/RunnerTests.build/RunnerTests-all-non-framework-target-headers.hmap -Xcc -ivfsoverlay -Xcc /Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Intermediates.noindex/Runner.build/Debug/RunnerTests.build/all-product-headers.yaml -Xcc -iquote -Xcc /Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Intermediates.noindex/Runner.build/Debug/RunnerTests.build/RunnerTests-project-headers.hmap -Xcc -I/Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Products/Debug/include -Xcc -I/Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Products/Debug/in_app_purchase_storekit/in_app_purchase_storekit.framework/Headers -Xcc -I/Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Products/Debug/shared_preferences_foundation/shared_preferences_foundation.framework/Headers -Xcc -I/Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Products/Debug/OCMock/OCMock.framework/Headers -Xcc -I/Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Products/Debug/in_app_purchase_storekit/in_app_purchase_storekit.framework/Headers -Xcc -I/Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Products/Debug/shared_preferences_foundation/shared_preferences_foundation.framework/Headers -Xcc -I/Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Intermediates.noindex/Runner.build/Debug/RunnerTests.build/DerivedSources-normal/arm64 -Xcc -I/Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Intermediates.noindex/Runner.build/Debug/RunnerTests.build/DerivedSources/arm64 -Xcc -I/Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Intermediates.noindex/Runner.build/Debug/RunnerTests.build/DerivedSources -Xcc -DDEBUG\=1 -Xcc -DCOCOAPODS\=1 -Xcc -DCOCOAPODS\=1 -import-objc-header /Volumes/Work/s/w/ir/x/w/packages/packages/in_app_purchase/in_app_purchase_storekit/example/macos/RunnerTests/RunnerTests-Bridging-Header.h -module-name RunnerTests -disable-clang-spi -target-sdk-version 14.0 -target-sdk-name macosx14.0 -external-plugin-path /Volumes/Work/s/w/ir/cache/osx_sdk/xcode_15a240d/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk/usr/lib/swift/host/plugins\#/Volumes/Work/s/w/ir/cache/osx_sdk/xcode_15a240d/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk/usr/bin/swift-plugin-server -external-plugin-path /Volumes/Work/s/w/ir/cache/osx_sdk/xcode_15a240d/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk/usr/local/lib/swift/host/plugins\#/Volumes/Work/s/w/ir/cache/osx_sdk/xcode_15a240d/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk/usr/bin/swift-plugin-server -external-plugin-path /Volumes/Work/s/w/ir/cache/osx_sdk/xcode_15a240d/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/lib/swift/host/plugins\#/Volumes/Work/s/w/ir/cache/osx_sdk/xcode_15a240d/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/bin/swift-plugin-server -external-plugin-path /Volumes/Work/s/w/ir/cache/osx_sdk/xcode_15a240d/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/local/lib/swift/host/plugins\#/Volumes/Work/s/w/ir/cache/osx_sdk/xcode_15a240d/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/bin/swift-plugin-server -plugin-path /Volumes/Work/s/w/ir/cache/osx_sdk/xcode_15a240d/XCode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/host/plugins -plugin-path /Volumes/Work/s/w/ir/cache/osx_sdk/xcode_15a240d/XCode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/local/lib/swift/host/plugins -index-store-path /Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Index.noindex/DataStore -serialize-diagnostics-path /Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Intermediates.noindex/PrecompiledHeaders/RunnerTests-Bridging-Header-dmi8xq9h13gd.dia /Volumes/Work/s/w/ir/x/w/packages/packages/in_app_purchase/in_app_purchase_storekit/example/macos/RunnerTests/RunnerTests-Bridging-Header.h -index-store-path /Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Index.noindex/DataStore -emit-pch -pch-output-dir /Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-cqhwqvjiontyvddtpbfbwdhoqskw/Build/Intermediates.noindex/PrecompiledHeaders
<unknown>:0: error: module map file '/Volumes/Work/s/w/ir/x/w/packages/packages/in_app_purchase/in_app_purchase_storekit/example/macos/Pods/Headers/Public/in_app_purchase_storekit/in_app_purchase_storekit.modulemap' not found
<unknown>:0: error: module map file '/Volumes/Work/s/w/ir/x/w/packages/packages/in_app_purchase/in_app_purchase_storekit/example/macos/Pods/Headers/Public/integration_test/integration_test.modulemap' not found
<unknown>:0: error: module map file '/Volumes/Work/s/w/ir/x/w/packages/packages/in_app_purchase/in_app_purchase_storekit/example/macos/Pods/Headers/Public/shared_preferences_macos/shared_preferences_macos.modulemap' not found
Command SwiftGeneratePch emitted errors but did not return a nonzero exit code to indicate failure

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8749646386009370081/+/u/Run_package_tests/native_test/stdout

I believe the OTHER_SWIFT_FLAGS in the macOS project is set up incorrectly:

packages/packages/in_app_purchase/in_app_purchase_storekit/example/macos/Runner.xcodeproj/project.pbxproj

Line 770 in 26bd37b

    
           OTHER_SWIFT_FLAGS = "$(inherited) -D COCOAPODS -Xcc -fmodule-map-file=\"${PODS_ROOT}/Headers/Public/in_app_purchase_storekit/in_app_purchase_storekit.modulemap\" -Xcc -fmodule-map-file=\"${PODS_ROOT}/Headers/Public/integration_test/integration_test.modulemap\" -Xcc -fmodule-map-file=\"${PODS_ROOT}/Headers/Public/shared_preferences_macos/shared_preferences_macos.modulemap\"";

From the original commit of the project:
https://github.com/flutter/plugins/pull/6517/files#diff-0baa9bfc86ab566e4f94f744d8fa57d187570868e84706c04b21b8ced0a6fedaR769

jmagman · 2024-05-01T01:20:57Z

...ages/in_app_purchase/in_app_purchase_storekit/example/macos/Runner.xcodeproj/project.pbxproj

@@ -773,7 +773,6 @@
 				MARKETING_VERSION = 1.0;
 				MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
 				MTL_FAST_MATH = YES;
-				OTHER_SWIFT_FLAGS = "$(inherited) -D COCOAPODS -Xcc -fmodule-map-file=\"${PODS_ROOT}/Headers/Public/in_app_purchase_storekit/in_app_purchase_storekit.modulemap\" -Xcc -fmodule-map-file=\"${PODS_ROOT}/Headers/Public/integration_test/integration_test.modulemap\" -Xcc -fmodule-map-file=\"${PODS_ROOT}/Headers/Public/shared_preferences_macos/shared_preferences_macos.modulemap\"";


There are two more of these I believe, one for each configuration.

hellohuanlin · 2024-05-06T17:54:18Z

is it ready for another review?

LouiseHsu · 2024-05-06T20:44:04Z

is it ready for another review?

@hellohuanlin Yeah, please take a look when you can!

packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/in_app_purchase_storekit.h

hellohuanlin · 2024-05-06T21:41:12Z

packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/messages.g.h

@@ -1,7 +1,7 @@
 // Copyright 2013 The Flutter Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-// Autogenerated from Pigeon (v16.0.4), do not edit directly.
+// Autogenerated from Pigeon (v16.0.5), do not edit directly.


is this bump required for this pr?

no, it just gets regenerated. is it worth going down a version to avoid these comment changes?

no need to regenerate. just don't check-in the changes that's not related to this PR.

hellohuanlin · 2024-05-06T21:47:53Z

packages/in_app_purchase/in_app_purchase_storekit/pigeons/messages.dart

@@ -238,7 +238,7 @@ abstract class InAppPurchaseAPI {
  SKProductsResponseMessage startProductRequest(
      List<String> productIdentifiers);

-  void finishTransaction(Map<String, String?> finishMap);
+  void finishTransaction(Map<String, Object?> finishMap);


packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/InAppPurchasePlugin.swift

hellohuanlin · 2024-05-06T22:20:43Z

packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/InAppPurchasePlugin.swift

+    return value is NSNull ? nil : value
+  }
+
+  func getRefreshReceiptRequest(properties: [String: Any]?) -> SKReceiptRefreshRequest {


packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/InAppPurchasePlugin.swift

hellohuanlin

I started the review, but unless im mistaken, it looks like a few previous comments have not been addressed. can you make sure all previous comments are addressed before i continue?

hellohuanlin · 2024-05-08T17:16:35Z

packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/InAppPurchasePlugin.swift

+#endif
+
+public class InAppPurchasePlugin: NSObject, FlutterPlugin, InAppPurchaseAPI {
+  // Properties


no need this comment

packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/InAppPurchasePlugin.swift

hellohuanlin

Getting very close

packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/InAppPurchasePlugin.swift

…ithout-pigeon

packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/InAppPurchasePlugin.swift

hellohuanlin · 2024-05-13T19:50:14Z

packages/in_app_purchase/in_app_purchase_storekit/pigeons/messages.dart

@@ -238,7 +238,7 @@ abstract class InAppPurchaseAPI {
  SKProductsResponseMessage startProductRequest(
      List<String> productIdentifiers);

-  void finishTransaction(Map<String, String?> finishMap);
+  void finishTransaction(Map<String, Object?> finishMap);


Using Any to represent an optional can be error-prone.
Why do you want [String:String?]? Is there any issue with using [String:String]?

hellohuanlin

LGTM! Thanks for making all the changes! Please make sure to manually test out if the feature still works as expected.

tests passes, pre-clean up

19393dd

github-actions bot added p: in_app_purchase platform-ios platform-macos labels Apr 17, 2024

formatting, clean up, comments

839394b

LouiseHsu commented Apr 18, 2024

View reviewed changes

packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/in_app_purchase_storekit.h Show resolved Hide resolved

LouiseHsu added 3 commits April 18, 2024 12:42

fix pod spec, licensing

dfa4937

Merge branch 'main' into without-pigeon

0f6bad5

version bump, fixed some typing

ccdcb28

LouiseHsu commented Apr 18, 2024

View reviewed changes

LouiseHsu requested a review from hellohuanlin April 18, 2024 19:54

LouiseHsu marked this pull request as ready for review April 18, 2024 19:54

LouiseHsu added 2 commits April 24, 2024 10:42

format

e0c1167

fix warnings

c3d956d

LouiseHsu requested a review from jmagman April 24, 2024 18:31

hellohuanlin reviewed Apr 24, 2024

View reviewed changes

LouiseHsu marked this pull request as draft April 24, 2024 19:52

LouiseHsu added 5 commits April 24, 2024 15:51

podspec

c8fd1ba

podspec

3d1a1ab

fix macos not building?

2d09254

add stubs for mac

74c4dfb

fix macos tests not launcing

6c94568

SpajicM mentioned this pull request Apr 27, 2024

[in_app_purchase] Use StoreKit 2 APIs flutter/flutter#116383

Open

remove OTHER_SWIFT_FLAGS (macos tests)

1c7d79b

jmagman reviewed May 1, 2024

View reviewed changes

LouiseHsu added 2 commits May 1, 2024 11:12

fix refreshReceipt test to not trigger authentication

7d144c0

remove the worst swift flag known to man

941952d

LouiseHsu added 2 commits May 2, 2024 16:33

Merge branch 'main' into without-pigeon

0628be6

pubspec 💀

74de10a

LouiseHsu marked this pull request as ready for review May 2, 2024 23:37

hellohuanlin reviewed May 6, 2024

View reviewed changes

pr comments

b300519

LouiseHsu requested a review from hellohuanlin May 7, 2024 23:54

hellohuanlin reviewed May 8, 2024

View reviewed changes

LouiseHsu added 2 commits May 8, 2024 10:43

comments

b96d592

comment

ed4467f

LouiseHsu requested a review from hellohuanlin May 8, 2024 18:19

hellohuanlin reviewed May 8, 2024

View reviewed changes

LouiseHsu added 2 commits May 8, 2024 17:02

some pr comments

59c5e82

pr comments

f53c606

LouiseHsu requested a review from hellohuanlin May 9, 2024 22:44

hellohuanlin reviewed May 9, 2024

View reviewed changes

LouiseHsu added 5 commits May 9, 2024 17:13

more pr comments

c1fb882

remove extra init

9912039

Merge branch 'main' into without-pigeon

342c3c7

comments

1afb1b9

Merge branch 'without-pigeon' of github.com:LouiseHsu/packages into w…

e183f40

…ithout-pigeon

LouiseHsu requested a review from hellohuanlin May 13, 2024 19:00

hellohuanlin reviewed May 13, 2024

View reviewed changes

comments

51c47db

LouiseHsu requested a review from hellohuanlin May 13, 2024 20:25

LouiseHsu added 2 commits May 14, 2024 11:37

pr cmments

44fbb4a

pr comments

7e48e2a

hellohuanlin approved these changes May 14, 2024

View reviewed changes

LouiseHsu merged commit 2f35b83 into flutter:main May 14, 2024
74 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[in_app_purchase_storekit] migrate main plugin class to swift in preperation to storekit 2 #6561

[in_app_purchase_storekit] migrate main plugin class to swift in preperation to storekit 2 #6561

LouiseHsu commented Apr 17, 2024 •

edited

LouiseHsu Apr 18, 2024

hellohuanlin Apr 24, 2024

hellohuanlin May 6, 2024

LouiseHsu May 7, 2024

hellohuanlin May 13, 2024

hellohuanlin May 13, 2024

LouiseHsu May 13, 2024

LouiseHsu May 13, 2024 •

edited

LouiseHsu May 13, 2024 •

edited

hellohuanlin May 13, 2024

LouiseHsu Apr 18, 2024

hellohuanlin commented Apr 19, 2024

hellohuanlin left a comment

hellohuanlin Apr 24, 2024

hellohuanlin Apr 24, 2024

hellohuanlin May 6, 2024

LouiseHsu May 7, 2024

hellohuanlin Apr 24, 2024

hellohuanlin Apr 24, 2024

jmagman commented Apr 30, 2024

jmagman May 1, 2024

hellohuanlin commented May 6, 2024

LouiseHsu commented May 6, 2024

hellohuanlin May 6, 2024

LouiseHsu May 7, 2024

hellohuanlin May 7, 2024

hellohuanlin May 6, 2024

hellohuanlin May 6, 2024

hellohuanlin left a comment

hellohuanlin May 8, 2024

hellohuanlin left a comment

hellohuanlin May 13, 2024

hellohuanlin left a comment

		@@ -144,28 +144,6 @@ - (instancetype)initWithMap:(NSDictionary *)map {

		@end

		@interface InAppPurchasePluginStub ()

[in_app_purchase_storekit] migrate main plugin class to swift in preperation to storekit 2 #6561

[in_app_purchase_storekit] migrate main plugin class to swift in preperation to storekit 2 #6561

Conversation

LouiseHsu commented Apr 17, 2024 • edited

Pre-launch Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LouiseHsu May 13, 2024 • edited

Choose a reason for hiding this comment

LouiseHsu May 13, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hellohuanlin commented Apr 19, 2024

hellohuanlin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmagman commented Apr 30, 2024

Choose a reason for hiding this comment

hellohuanlin commented May 6, 2024

LouiseHsu commented May 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hellohuanlin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hellohuanlin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hellohuanlin left a comment

Choose a reason for hiding this comment

LouiseHsu commented Apr 17, 2024 •

edited

LouiseHsu May 13, 2024 •

edited

LouiseHsu May 13, 2024 •

edited