Make Fragment symbol comparable across module instances #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When debugging Forgo using `npm link`, Vite's pre-bundling optimization executes the `forgo` module twice ([Vite bug](vitejs/vite#3910), [Svelte bug with workarounds](sveltejs/vite-plugin-svelte#135 (comment))). It doesn't happen when using the package from npm. This results in different code paths holding references to two different `Fragment` symbols, causing renders to fail because the two symbols aren't comparable using `===`. Using `Symbol.for()` makes all symbols named `FORGO_FRAGMENT` comparable, no matter where they come from. Alternatively, there's a workaround to have Vite disable pre-bundling optimizations for `forgo`, but this patch makes that unnecessary.
|
Makes sense. Thanks! Two tests fail because the re-ordering issue you reported earlier is still unfixed (I haven't found enough time yet, and it's a lot of work). Please ignore those failing tests for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging Forgo using
npm link, Vite's pre-bundling optimization executes theforgomodule twice (Vite bug, Svelte bug with workarounds). It doesn't happen when using the package from npm.This results in different code paths holding references to two different
Fragmentsymbols, causing renders to fail because the two symbols aren't comparable using===. UsingSymbol.for()makes all symbols namedFORGO_FRAGMENTcomparable, no matter where they come from.Alternatively, there's a workaround to have Vite disable pre-bundling optimizations for
forgo, but this patch makes that unnecessary.