Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Fragment symbol comparable across module instances #36

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Make Fragment symbol comparable across module instances #36

merged 1 commit into from
Jan 14, 2022

Commits on Jan 13, 2022

  1. Make Fragment symbol comparable across module instances 

    When debugging Forgo using `npm link`, Vite's pre-bundling optimization executes the `forgo` module twice ([Vite bug](vitejs/vite#3910), [Svelte bug with workarounds](sveltejs/vite-plugin-svelte#135 (comment))). It doesn't happen when using the package from npm.

This results in different code paths holding references to two different `Fragment` symbols, causing renders to fail because the two symbols aren't comparable using `===`. Using `Symbol.for()` makes all symbols named `FORGO_FRAGMENT` comparable, no matter where they come from.

Alternatively, there's a workaround to have Vite disable pre-bundling optimizations for `forgo`, but this patch makes that unnecessary.
    @spiffytech
    spiffytech committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    3f91bd4 View commit details
    Browse the repository at this point in the history