Cast undefined value to empty string #417
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An undefined value in append will cause a confusing error:
`TypeError: Cannot read property 'name' of undefined`
Typically it's no problem to encode a form with undefined values into
a querystring. Using this package to send binary data, one must be
careful that all form values are defined.
Simple fix here is casting to empty string
To repro:
```js
var data = {};
var FormData = require('form-data');
var form = new FormData();
form.on('error', console.log);
form.append('woops', data.woops);
```
fijimunkii
added a commit
to fijimunkii/request
that referenced
this pull request
Jan 25, 2019
One must be careful that all formData values are not undefined
An undefined value in form-data append will cause a confusing error:
`TypeError: Cannot read property 'name' of undefined`
Simple fix here is casting to empty string
To repro:
```js
var formData = { woops: undefined };
var request = require('request');
request('https://github.com', { formData }, console.log)
```
Related PR to fix form-data form-data/form-data#417
This was referenced Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An undefined value in append will cause a confusing error:
TypeError: Cannot read property 'name' of undefinedTypically it's no problem to encode a form with undefined values into a querystring. Using this package to send binary data, one must be careful that all form values are defined.
Simple fix here is casting to empty string
To repro: