Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast undefined value to empty string #417

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jan 25, 2019

  1. Cast undefined value to empty string

    An undefined value in append will cause a confusing error:
    `TypeError: Cannot read property 'name' of undefined`
    
    Typically it's no problem to encode a form with undefined values into
    a querystring. Using this package to send binary data, one must be
    careful that all form values are defined.
    
    Simple fix here is casting to empty string
    
    To repro:
    ```js
    var data = {};
    var FormData = require('form-data');
    var form = new FormData();
    form.on('error', console.log);
    form.append('woops', data.woops);
    ```
    fijimunkii committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    04e5f0d View commit details
    Browse the repository at this point in the history