Issue #485 Update browser.js to not throw with SSR #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates that browser.js does not throw when rendering on the server and window is not defined. Solves issue form-data#485
|
@coveralls any change that this can be merged? |
|
Can I do anything to help getting this merged? |
|
@3imed-jaberi Great! How can we get this merged? It's really annoying having to fix this manually each time. Can I help in any way? |
|
+1 for this being a great fix to include! |
|
This issue is breaking my webpack build imports. Any chance we can get this merged in. I know it's been awhile but it's needed especially with Axios. |
|
Can you please merge it ? |
|
We're waiting on GitHub access then we can merge and release. |
|
Would love for this to get merged in! |
WesleyKapow
added a commit
to zeus-health/ctw-component-library
that referenced
this pull request
Mar 31, 2023
Patch is from form-data/form-data#496 Issue in graphql-request: jasonkuhrt/graphql-request#362
mrosata
pushed a commit
to zeus-health/ctw-component-library
that referenced
this pull request
Mar 31, 2023
See jasonkuhrt/graphql-request#362 (comment) We're now forcing form-data to v4 AND providing the patch from form-data/form-data#496. This fixes the issue when trying to run this in SSR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates that browser.js does not throw when rendering on the server and window is not defined.
Solves issue #485