Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Jest, prepare for Vitest #4390

Closed
wants to merge 2 commits into from

Conversation

NullVoxPopuli
Copy link

Jest's lack of proper support for mjs files in cjs projects is blocking: #4376 (everything is fine at runtime, which is extra frustrating)

Here I try removing jest altogether.
I did see that there is a jest-specific package (a transformer), so I'll need to re-add jest to that package, but in general, it seems that this is making things much simpler (so far).

@longlho
Copy link
Member

longlho commented Apr 11, 2024

vitest needs to work with bazel so this PR won't work. Let me take a stab at this myself

@NullVoxPopuli
Copy link
Author

Locally things aren't ready yet, so idk how much time you want to spend on this 😅

@longlho
Copy link
Member

longlho commented Apr 11, 2024

I spent some time and it's non-trivial, likely because vitest isn't entirely hermetic. The tricky thing is to deal w/ snapshots testing & update which https://github.com/aspect-build/rules_jest handles for us already.

@NullVoxPopuli
Copy link
Author

Is the aspect needed? Running vitest from the repo root seems to find tests in all the sub packages?

@longlho
Copy link
Member

longlho commented May 5, 2024

closing this for now since this unlikely is going to happen.

@longlho longlho closed this May 5, 2024
@NullVoxPopuli
Copy link
Author

yeah, I think first, perhaps bazel would need to be removed 🤔

or someone that knows bazel better would need to take on this work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants