Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Jest, prepare for Vitest #4390

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ packages/cli/integration-tests/extract/typescript/err.tsx
**/*.generated.*
# Let Bazel manage this
rust/cargo-bazel-lock.json
# Snapshots managed by Jest
# Snapshots managed by Vitest
**/__snapshots__/*
# Changelog managed by Lerna
**/CHANGELOG.md
14 changes: 1 addition & 13 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,5 @@
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"type": "node",
"name": "jest intl-datetimeformat",
"request": "launch",
"cwd": "${workspaceFolder}/packages/intl-datetimeformat",
"console": "integratedTerminal",
"internalConsoleOptions": "neverOpen",
"disableOptimisticBPs": true,
"program": "${workspaceFolder}/node_modules/jest/bin/jest",
"args": ["--runInBand", "--coverage", "false"]
}
]
"configurations": []
}
2 changes: 1 addition & 1 deletion BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ multirun(
)

CONFIG_FILES = [
"jest.config.js",
"vitest.config.mts",
"package.json",
"tsconfig.json",
]
Expand Down
20 changes: 0 additions & 20 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -117,26 +117,6 @@ register_copy_directory_toolchains()

register_copy_to_directory_toolchains()

# Jest
http_archive(
name = "aspect_rules_jest",
sha256 = "d3bb833f74b8ad054e6bff5e41606ff10a62880cc99e4d480f4bdfa70add1ba7",
strip_prefix = "rules_jest-0.18.4",
url = "https://github.com/aspect-build/rules_jest/releases/download/v0.18.4/rules_jest-v0.18.4.tar.gz",
)

####################
# rules_jest setup #
####################
# Fetches the rules_jest dependencies.
# If you want to have a different version of some dependency,
# you should fetch it *before* calling this.
# Alternatively, you can skip calling this function, so long as you've
# already fetched all the dependencies.
load("@aspect_rules_jest//jest:dependencies.bzl", "rules_jest_dependencies")

rules_jest_dependencies()

# Multirun

http_archive(
Expand Down
1 change: 1 addition & 0 deletions buildbuddy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ actions:
bazel_commands:
# Check if all files are properly formatted.
- 'run //:format -- --mode check'
- 'pnpm vitest'
- 'test //...'
7 changes: 0 additions & 7 deletions jest.config.js

This file was deleted.