Update Cypress and Jest versions and remove Node 8 support #543

luisherranz · 2020-08-25T09:30:04Z

What:

I've updated Cypress and Jest to their latest versions.

I've deprecated the URL import from "frontity", which was the only thing we had for backward compatibility with Node 8.

I've also fixed a couple of issues with Cypress e2e tests:

Remove WP CLI containers after run.
Remove all the containers (WP, MySQL, WP CLI) after Cypress has sucessfully run.
Remove all the containers after an error.

Why:

We've made several changes to our test system, I think it's good to keep it up to date with the latest Jest/Cypress versions.

Nobody supports Node 8 anymore. I think it's not even on maintenance anymore. All serverless platforms have updated to either Node 10 or Node 12. https://nodejs.org/en/about/releases/

How:

Simply by updating the dependencies and creating a wrapper around URL to warn about the deprecation.

Tasks:

Code
Unit tests
Add a changeset (with link to its Feature Discussion if it exists)

Unrelated Tasks

Additional Comments

I've added a dummy test to the end of the wp-basic-tests e2e tests, because if not Cypress was ignoring the previous test. I guess this is a bug in Cypress, maybe related to the after function.

It looks like it was useful to remove the container after the run.

It seems like a bug in Cypress when you use the `after` function.

changeset-bot · 2020-08-25T09:30:08Z

🦋 Changeset is good to go

Latest commit: a178a8c

We got this.

This PR includes changesets to release 1 package

Name	Type
frontity	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2020-08-25T09:32:29Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	1	0
Ignored	0	N/A

Result: ✅ success
Annotations: 1 total

[warning] jest/no-disabled-tests

Disallow disabled tests

packages/connect/src/tests/batching.tests.jsx Line 64 - Skipped test

^{Report generated by eslint-plus-action}

Skip because it started failing when we upgraded to Jest 26, but we are going to remove it once we merge this PR anyway: #415.

codecov · 2020-08-25T09:59:50Z

Codecov Report

Merging #543 into dev will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted Files	Coverage Δ
packages/frontity/src/index.ts	`100.00% <100.00%> (ø)`
packages/frontity/src/utils/url.ts	`100.00% <100.00%> (ø)`
packages/head-tags/src/utils/index.ts	`97.65% <100.00%> (-0.10%)`	⬇️
packages/wp-comments/src/index.ts	`92.99% <100.00%> (ø)`
packages/wp-source/src/actions.ts	`91.76% <100.00%> (ø)`
packages/components/script.tsx	`0.00% <0.00%> (ø)`
packages/google-analytics/src/index.ts	`29.17% <0.00%> (ø)`
packages/analytics/src/components/index.tsx	`26.67% <0.00%> (ø)`
packages/google-tag-manager-analytics/src/index.ts	`0.00% <0.00%> (ø)`
... and 1 more

Because I added them in this branch: https://github.com/frontity/frontity/tree/package-name

michalczaplinski · 2020-08-25T18:24:48Z

e2e/packages/ads/src/index.tsx

+/* eslint-disable */
+/*
+ * TSDocs will be added in this branch:
+ * https://github.com/frontity/frontity/tree/package-name


~~Is this correct? I see that the last commit on that branch was 8 days ago.~~

Oh, I see that it's in other files as well. I assume that you had a good reason for doing this but in general I would say that we shouldn't keep track of tasks this way because it's asking for trouble once it's merged and someone forgets 😅

You're right, it's not a good approach. I should've copied the TSDocs from that branch 👍

michalczaplinski · 2020-08-25T18:31:49Z

e2e/plugins/index.js

@@ -25,7 +25,7 @@ module.exports = (on, config) => {
    installPlugin({ name, version }) {
      return (async () => {
        await execa.command(
-          `docker-compose run wpcli wp plugin install ${name}${
+          `docker-compose run --rm wpcli wp plugin install ${name}${


👍 when running locally it leaves lotsa containers behind, good point.

michalczaplinski · 2020-08-25T18:37:46Z

packages/frontity/src/utils/decode/__tests__/decode.test.ts

@@ -9,7 +9,7 @@ const mockedHe = he as jest.Mocked<typeof he>;
 describe("decode", () => {
  beforeEach(() => {
    mockedHe.decode.mockReset();
-    mockedHe.decode.mockImplementation(require.requireActual("he").decode);
+    mockedHe.decode.mockImplementation(jest.requireActual("he").decode);


Just leaving this for reference: jestjs/jest#9854. This change is because of jest deprecating require.requireActual()

michalczaplinski

Not strictly related to the changes in the PR, but I've noticed that the URL constructor is not supported at all in IE so as far as I can tell that means that we don't support IE at all.

Based on https://community.frontity.org/t/frontity-support-for-ie9/2540/5?u=mmczaplinski we decided to support IE11 SSR-only so that would break this promise.

luisherranz · 2020-08-26T06:51:26Z

Based on https://community.frontity.org/t/frontity-support-for-ie9/2540/5?u=mmczaplinski we decided to support IE11 SSR-only so that would break this promise.

The client-code it's not executed in IE because it's server-side only. So URL is safe to use because it will run only in the server 👍

This hasn't changed in this PR. We were already using window.URL for the client before: https://github.com/frontity/frontity/blob/dev/packages/core/src/config/webpack/externals.ts#L12

Thanks for the review and the comments @michalczaplinski! 🙂

github-actions · 2020-08-26T06:56:52Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	1	0
Ignored	0	N/A

Result: ✅ success
Annotations: 1 total

[warning] jest/no-disabled-tests

Disallow disabled tests

packages/connect/src/tests/batching.tests.jsx Line 64 - Skipped test

^{Report generated by eslint-plus-action}

michalczaplinski · 2020-08-26T14:58:05Z

The client-code it's not executed in IE because it's server-side only. So URL is safe to use because it will run only in the server 👍

oh, I think I was tired yesterday since the answer was in my own question basically 🤦‍♂️ Thanks @luisherranz :)

luisherranz · 2020-08-26T15:21:39Z

oh, I think I was tired yesterday since the answer was in my own question basically

Haha, that's true 😄

luisherranz added 6 commits August 25, 2020 10:48

Update Jest

d399312

Update Cypress

f06537d

Add --rm option again

f6668db

It looks like it was useful to remove the container after the run.

Remove all containers after Cypress runs

ec10a02

Remove containers also on failure

661bc3e

Fix last test not running

88c8b7b

It seems like a bug in Cypress when you use the `after` function.

luisherranz requested a review from DAreRodz August 25, 2020 09:30

luisherranz self-assigned this Aug 25, 2020

luisherranz changed the title ~~Update cypress jest~~ Update Cypress and Jest versions Aug 25, 2020

Skip failing connect test

58d4752

Skip because it started failing when we upgraded to Jest 26, but we are going to remove it once we merge this PR anyway: #415.

luisherranz removed the request for review from DAreRodz August 25, 2020 09:46

luisherranz marked this pull request as draft August 25, 2020 09:46

luisherranz added 2 commits August 25, 2020 11:46

Remove Node 8 support

bc9bfbf

Fix decode test

1766325

Deprecate url

1d30ad7

luisherranz changed the title ~~Update Cypress and Jest versions~~ Update Cypress and Jest versions and remove Node 8 support Aug 25, 2020

Add changeset

6ece281

luisherranz mentioned this pull request Aug 25, 2020

Remove URL from frontity exports frontity/docs#206

Merged

luisherranz added 4 commits August 25, 2020 13:43

Remove the URL import from packages

38c3576

Do not add TSDocs for the e2e packages

7bae296

Because I added them in this branch: https://github.com/frontity/frontity/tree/package-name

Replace console.warn with Frontity's warn

633adb3

Update TSDocs on head tags file

a178a8c

luisherranz requested a review from michalczaplinski August 25, 2020 16:03

luisherranz marked this pull request as ready for review August 25, 2020 16:03

luisherranz added this to In progress in Sprint 6 via automation Aug 25, 2020

luisherranz moved this from In progress to In review in Sprint 6 Aug 25, 2020

michalczaplinski reviewed Aug 25, 2020

View reviewed changes

michalczaplinski self-requested a review August 25, 2020 18:52

michalczaplinski approved these changes Aug 25, 2020

View reviewed changes

michalczaplinski reviewed Aug 26, 2020

View reviewed changes

luisherranz merged commit 18465df into dev Aug 26, 2020

Sprint 6 automation moved this from In review to Done Aug 26, 2020

luisherranz deleted the update-cypress-jest branch August 26, 2020 06:54

This was referenced Sep 3, 2020

Version Packages #552

Closed

Version Packages #554

Closed

Version Packages #555

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Cypress and Jest versions and remove Node 8 support #543

Update Cypress and Jest versions and remove Node 8 support #543

luisherranz commented Aug 25, 2020 •

edited

changeset-bot bot commented Aug 25, 2020 •

edited

github-actions bot commented Aug 25, 2020 •

edited

codecov bot commented Aug 25, 2020 •

edited

michalczaplinski Aug 25, 2020 •

edited

luisherranz Aug 26, 2020

michalczaplinski Aug 25, 2020

michalczaplinski Aug 25, 2020 •

edited

michalczaplinski left a comment

luisherranz commented Aug 26, 2020 •

edited

github-actions bot commented Aug 26, 2020

michalczaplinski commented Aug 26, 2020

luisherranz commented Aug 26, 2020

Update Cypress and Jest versions and remove Node 8 support #543

Update Cypress and Jest versions and remove Node 8 support #543

Conversation

luisherranz commented Aug 25, 2020 • edited

changeset-bot bot commented Aug 25, 2020 • edited

🦋 Changeset is good to go

github-actions bot commented Aug 25, 2020 • edited

ESLint Summary View Full Report

[warning] jest/no-disabled-tests

codecov bot commented Aug 25, 2020 • edited

Codecov Report

michalczaplinski Aug 25, 2020 • edited

Choose a reason for hiding this comment

luisherranz Aug 26, 2020

Choose a reason for hiding this comment

michalczaplinski Aug 25, 2020

Choose a reason for hiding this comment

michalczaplinski Aug 25, 2020 • edited

Choose a reason for hiding this comment

michalczaplinski left a comment

Choose a reason for hiding this comment

luisherranz commented Aug 26, 2020 • edited

github-actions bot commented Aug 26, 2020

ESLint Summary View Full Report

[warning] jest/no-disabled-tests

michalczaplinski commented Aug 26, 2020

luisherranz commented Aug 26, 2020

luisherranz commented Aug 25, 2020 •

edited

changeset-bot bot commented Aug 25, 2020 •

edited

github-actions bot commented Aug 25, 2020 •

edited

codecov bot commented Aug 25, 2020 •

edited

michalczaplinski Aug 25, 2020 •

edited

michalczaplinski Aug 25, 2020 •

edited

luisherranz commented Aug 26, 2020 •

edited