New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the Image
component AMP-aware
#826
Conversation
🦋 Changeset detectedLatest commit: 5d41a34 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Now, that the
In order to avoid bikeshedding about it, I went ahead and changed the references to |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
2d2ca82
to
5df1b99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! I love when we remove code 😄
Thanks Michal!
ESLint Summary View Full Report
Report generated by eslint-plus-action |
What:
Make the
@frontity/components/Image
AMP-aware and remove the Intersection Observer fallback which used to lazily load images in the absence of native lazy loading.Why:
To complete making AMP a first-class citizen in Frontity: https://community.frontity.org/t/amp-package/388/
How:
Check if the
state.frontity.mode === "amp"
Tasks:
Unrelated Tasks
Additional Comments
Not linking the issue because I don't want to close it yet when this PR is merged.