Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add double tapping to mobile and don't allow both single and double tap events to fire #1381

Merged
merged 19 commits into from Oct 11, 2020
Merged

Add double tapping to mobile and don't allow both single and double tap events to fire #1381

merged 19 commits into from Oct 11, 2020

Conversation

okratitan
Copy link
Member

Description:

This keeps Tapped and DoubleTapped from both being called when DoubleTapped occurs

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style.
  • Any breaking changes have a deprecation path or have been discussed.

@okratitan okratitan marked this pull request as draft October 9, 2020 21:04
@okratitan okratitan marked this pull request as ready for review October 9, 2020 21:27
stuartmscott
stuartmscott reviewed Oct 9, 2020
View reviewed changes
Copy link
Member

@stuartmscott stuartmscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, but requested review from those more familiar

@okratitan okratitan changed the title Don't call Tapped until we are sure the Tapped isn't a DoubleTapped Add double tapping to mobile and don't allow both single and double tap events to fie Oct 10, 2020
@okratitan okratitan changed the title Add double tapping to mobile and don't allow both single and double tap events to fie Add double tapping to mobile and don't allow both single and double tap events to fire Oct 10, 2020
stuartmscott
stuartmscott reviewed Oct 10, 2020
View reviewed changes
internal/driver/gomobile/canvas.go Outdated Show resolved Hide resolved
internal/driver/glfw/window_test.go Show resolved Hide resolved
internal/driver/glfw/window.go Outdated Show resolved Hide resolved
stuartmscott
stuartmscott previously approved these changes Oct 10, 2020
View reviewed changes
@stuartmscott stuartmscott merged commit cd5ca3c into fyne-io:develop Oct 11, 2020
andydotxyz
andydotxyz reviewed Oct 11, 2020
View reviewed changes
internal/driver/glfw/window_test.go

w.mouseClicked(w.viewport, glfw.MouseButton1, glfw.Press, 0)
w.mouseClicked(w.viewport, glfw.MouseButton1, glfw.Release, 0)
w.waitForEvents()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this seemed superflouos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz left review comments

@stuartmscott stuartmscott stuartmscott approved these changes

@toaster toaster Awaiting requested review from toaster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@okratitan @andydotxyz @stuartmscott