New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add double tapping to mobile and don't allow both single and double tap events to fire #1381
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a28e35d
Don't call Tapped until we are sure the Tapped isn't a DoubleTapped
okratitan b35ed84
Oops didn't mean to remove that line
okratitan 2e0b38b
500 ms is too long to way for a click.
okratitan ed3e94d
Only wait on tap if the canvas object is double tappable
okratitan 63408a0
Add test.DoubleTap for use with test objects testingn double taps
okratitan 3c05226
Fix issues with single taps, add a test for issue
okratitan 0e6d6a0
Check for double tappable in finding object
okratitan 50a52a9
Fix formatting
okratitan a68f8ad
Add mobile support for double tapping
okratitan c10715a
Return from a cancelled double tap before starting go routine
okratitan e68037c
Fix formatting
okratitan 7677100
Thanks to Jacob for the frequent formatting failure reminders
okratitan fec7c1c
Remove unecessary select {} for one case statements
okratitan bd15c5e
Fix formattingFix formattin
okratitan b3ad7b9
Merge branch 'develop' into doubleTapFix
okratitan f91191c
Fix broken mobile tests and add a test for double clicking on mobile
okratitan b55408c
Merge branch 'doubleTapFix' of https://github.com/okratitan/fyne into…
okratitan aacecf5
Fix formatting again
okratitan d8a3471
Merge branch 'develop' into doubleTapFix
stuartmscott File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this seemed superflouos