Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add double tapping to mobile and don't allow both single and double tap events to fire #1381

Merged
merged 19 commits into from Oct 11, 2020
Merged

Add double tapping to mobile and don't allow both single and double tap events to fire #1381

merged 19 commits into from Oct 11, 2020

Commits on Oct 9, 2020

  1. Don't call Tapped until we are sure the Tapped isn't a DoubleTapped

    @okratitan
    okratitan committed Oct 9, 2020
    Copy the full SHA
    a28e35d View commit details
    Browse the repository at this point in the history

  2. Oops didn't mean to remove that line

    @okratitan
    okratitan committed Oct 9, 2020
    Copy the full SHA
    b35ed84 View commit details
    Browse the repository at this point in the history

  3. 500 ms is too long to way for a click.

    @okratitan
    okratitan committed Oct 9, 2020
    Copy the full SHA
    2e0b38b View commit details
    Browse the repository at this point in the history

  4. Only wait on tap if the canvas object is double tappable

    @okratitan
    okratitan committed Oct 9, 2020
    Copy the full SHA
    ed3e94d View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2020

  1. Add test.DoubleTap for use with test objects testingn double taps

    @okratitan
    okratitan committed Oct 10, 2020
    Copy the full SHA
    63408a0 View commit details
    Browse the repository at this point in the history

  2. Fix issues with single taps, add a test for issue

    @okratitan
    okratitan committed Oct 10, 2020
    Copy the full SHA
    3c05226 View commit details
    Browse the repository at this point in the history

  3. Check for double tappable in finding object

    @okratitan
    okratitan committed Oct 10, 2020
    Copy the full SHA
    0e6d6a0 View commit details
    Browse the repository at this point in the history

  4. Fix formatting

    @okratitan
    okratitan committed Oct 10, 2020
    Copy the full SHA
    50a52a9 View commit details
    Browse the repository at this point in the history

  5. Add mobile support for double tapping

    @okratitan
    okratitan committed Oct 10, 2020
    Copy the full SHA
    a68f8ad View commit details
    Browse the repository at this point in the history

  6. Return from a cancelled double tap before starting go routine

    @okratitan
    okratitan committed Oct 10, 2020
    Copy the full SHA
    c10715a View commit details
    Browse the repository at this point in the history

  7. Fix formatting

    @okratitan
    okratitan committed Oct 10, 2020
    Copy the full SHA
    e68037c View commit details
    Browse the repository at this point in the history

  8. Thanks to Jacob for the frequent formatting failure reminders

    @okratitan
    okratitan committed Oct 10, 2020
    Copy the full SHA
    7677100 View commit details
    Browse the repository at this point in the history

  9. Remove unecessary select {} for one case statements

    @okratitan
    okratitan committed Oct 10, 2020
    Copy the full SHA
    fec7c1c View commit details
    Browse the repository at this point in the history

  10. Fix formattingFix formattin

    @okratitan
    okratitan committed Oct 10, 2020
    Copy the full SHA
    bd15c5e View commit details
    Browse the repository at this point in the history

  11. Merge branch 'develop' into doubleTapFix

    @okratitan
    okratitan committed Oct 10, 2020
    Copy the full SHA
    b3ad7b9 View commit details
    Browse the repository at this point in the history

  12. Fix broken mobile tests and add a test for double clicking on mobile

    @okratitan
    okratitan committed Oct 10, 2020
    Copy the full SHA
    f91191c View commit details
    Browse the repository at this point in the history

  13. Merge branch 'doubleTapFix' of https://github.com/okratitan/fyne into… 

    … doubleTapFix
    @okratitan
    okratitan committed Oct 10, 2020
    Copy the full SHA
    b55408c View commit details
    Browse the repository at this point in the history

  14. Fix formatting again

    @okratitan
    okratitan committed Oct 10, 2020
    Copy the full SHA
    aacecf5 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2020

  1. Merge branch 'develop' into doubleTapFix

    @stuartmscott
    stuartmscott committed Oct 11, 2020
    Copy the full SHA
    d8a3471 View commit details
    Browse the repository at this point in the history