New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File dialog locations #1108
Closed
charlesdaniels
wants to merge
34
commits into
fyne-io:develop
from
charlesdaniels:file_dialog_locations
Closed
File dialog locations #1108
Changes from 23 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
9ec1249
file dialog: use ./ as start dir by default
charlesdaniels d0e337a
file dialog: Add ShowFile*At methods
charlesdaniels c5561ca
fixed linter errors
charlesdaniels db857e1
file dialog: break out effectiveStartingDir
charlesdaniels 6fbdb2f
add tests for effectiveStartingDir()
charlesdaniels be9c018
break out just effectiveStartingDir
charlesdaniels a20d4ed
Merge branch 'master' into file_dialog_locations
charlesdaniels ec1f970
Merge branch 'develop' into file_dialog_locations
charlesdaniels 7794089
make public API use ListableURI
charlesdaniels 7ee7b21
fix conditional check for ./
charlesdaniels 7a4a4a5
Migrate file dialog to use URIs throughout
charlesdaniels 78c6984
feedback for #1108
charlesdaniels 689a256
Merge branch 'develop' into file_dialog_locations
charlesdaniels e8a2269
try to fix WIndows build failures
charlesdaniels 59c5fb7
try again to fix Windows build failure
charlesdaniels de97723
try to implement Windows path support
charlesdaniels bc607aa
Merge branch 'develop' into file_dialog_locations
charlesdaniels 4d39cfd
fix staticcheck errors
charlesdaniels d46f9ff
try to fix windows paths
charlesdaniels 210fe34
Fix some issues related to ListableURI and dialog
PucklaJ 2916628
Replace fws with bws in setDirectory for windows
PucklaJ 9c055c7
Fix save and open dialog tests
PucklaJ f3e0660
Merge pull request #1 from PucklaMotzer09/file_dialog_locations_fixes
charlesdaniels 347e49a
Replace backslashes in NewURI
PucklaJ 5681882
Add tests for parentGeneric
PucklaJ 60a46e4
Improve tests and always end Parent with slash
PucklaJ b7a6dd8
Don't return as soon as one fails in loadFavorites
PucklaJ 20cbea5
Update breadcrumbs creation and add test for them
PucklaJ dc79d37
Remove checking for "file" scheme in setDirectory
PucklaJ d5ce136
Fix staticcheck
PucklaJ ac81a66
Merge pull request #2 from PucklaMotzer09/file_dialog_locations
charlesdaniels 45233fe
revert starting dir to ~, remove OpenAt functions
charlesdaniels ae3b91f
re-enable overwrite callback
charlesdaniels 5b5c3a3
update file dialog tests for ~ starting dir
charlesdaniels File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be needed as you are comparing a URI with a URI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it back since now all URIs just have
/