Refactoring: focus handling #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FocusManager no longer knows about the canvas. Instead the canvas creates a new FocusManager when its content is set. The canvas accesses its FocusManager to focus/unfocus objects.
With the move of focus next/previous to FocusManager the action lost the ability to notify the Focusable. This commit restores it and adds appropriate tests.
stuartmscott
approved these changes
Sep 12, 2020
andydotxyz
approved these changes
Sep 13, 2020
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This moves the handling of focused objects from canvas into the
FocusManager.It is a preparation for upcoming fixes of focus issues like #814 and #948.
Checklist: