Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: focus handling #1294

Merged
merged 10 commits into from Sep 14, 2020
Merged

Refactoring: focus handling #1294

merged 10 commits into from Sep 14, 2020

Commits on Sep 8, 2020

  1. sort non-exported functions of glfw/canvas

    @toaster
    toaster committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    b2ef44a View commit details
    Browse the repository at this point in the history

  2. use Max instead of Union in glfw/canvas

    @toaster
    toaster committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    6083e14 View commit details
    Browse the repository at this point in the history

  3. remove unnecessary !found from FocusManager

    @toaster
    toaster committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    6825029 View commit details
    Browse the repository at this point in the history

  4. move focus handling from canvas to FocusManager 

    The FocusManager no longer knows about the canvas.
Instead the canvas creates a new FocusManager when its content is set.
The canvas accesses its FocusManager to focus/unfocus objects.
    @toaster
    toaster committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    5300c5b View commit details
    Browse the repository at this point in the history

  5. add missing space in comment

    @toaster
    toaster committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    8d380dc View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2020

  1. move focus gained/lost notification from canvas to FocusManager

    @toaster
    toaster committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    a3be02b View commit details
    Browse the repository at this point in the history

  2. fix focus next/previous bug 

    With the move of focus next/previous to FocusManager the action
lost the ability to notify the Focusable.
This commit restores it and adds appropriate tests.
    @toaster
    toaster committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    83b4f9e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into refactoring/focus_handling

    @toaster
    toaster committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    328c444 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2020

  1. Merge branch 'develop' into refactoring/focus_handling

    @toaster
    toaster committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    474f279 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2020

  1. Merge branch 'develop' into refactoring/focus_handling

    @toaster
    toaster committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    10aa3ac View commit details
    Browse the repository at this point in the history