Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply min macOS version as 10.11 like the app store packaging #1612

Merged
merged 1 commit into from Nov 27, 2020

Conversation

andydotxyz
Copy link
Member

This suppports most computers sold in the last 12 years
and goes beyond Apple support plans.

Fixes #886

Can test with:
otool -l MyApp.app/Contents/MacOS/MyApp | grep -b4 VERSION_MIN_MACOSX

Checklist:

  • Tests included. <- manual inspection of the output binary
  • Lint and formatter run with no errors.
  • Tests all pass.

This suppports most computers sold in the last 12 years
and goes beyond Apple support plans.

Fixes fyne-io#886
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice change. Go 1.15 dropped support for 10.11, should we perhaps instead have 10.12 as the least supported?

@andydotxyz
Copy link
Member Author

Thanks, but I'm not sure I agree - We still support Go 1.12 so we cannot only support target platforms of Go 1.15.
The 32bit support was a little different as we litereally could not build the apps any more - but for OS versioning we should be OK to support older.

Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. The removal of 32bit in 1.15 was why I asked. Did not know that we literally couldn’t build them. Left a little suggestion, otherwise I think it is fine 🙂

cmd/fyne/commands/build.go Show resolved Hide resolved
@andydotxyz andydotxyz removed the request for review from lucor November 27, 2020 13:40
@andydotxyz andydotxyz merged commit e5f30d6 into fyne-io:release/v1.4.x Nov 27, 2020
@andydotxyz andydotxyz deleted the fix/886 branch November 27, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants