Allow custom themes to react theme variant changes, fixes #2006 #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andydotxyz
requested changes
Mar 1, 2021
fpabl0
commented
Mar 1, 2021
| @@ -76,16 +76,68 @@ func TestOverrideTheme_IgnoresSettingsChange(t *testing.T) { | |||
| } | |||
| set.setupTheme() | |||
| assert.Equal(t, theme.LightTheme(), set.Theme()) | |||
|
|
|||
There was a problem hiding this comment.
I have edited this test, by removing the behavior that ignores forever the changes in the application once FYNE_THEME env var is set at least once, is that ok?
There was a problem hiding this comment.
FYNE_THEME is an override, once set it should not be changed
There was a problem hiding this comment.
I don't think we had considered the env changing during runtime. That could go either way.
What I meant was that if env is set nothing else should influence the setting
andydotxyz
approved these changes
Mar 1, 2021
andydotxyz
pushed a commit
that referenced
this pull request
Mar 1, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #2006
Checklist: