Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop custom predicateutils.Or function #6364

Merged
merged 1 commit into from Jul 21, 2022
Merged

Drop custom predicateutils.Or function #6364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions extensions/pkg/controller/dnsrecord/controller.go
View file
Open in desktop
Expand Up @@ -24,7 +24,6 @@ import (
extensionspredicate "github.com/gardener/gardener/extensions/pkg/predicate"
extensionsv1alpha1 "github.com/gardener/gardener/pkg/apis/extensions/v1alpha1"
"github.com/gardener/gardener/pkg/controllerutils/mapper"
predicateutils "github.com/gardener/gardener/pkg/controllerutils/predicate"
)

const (
Expand Down Expand Up @@ -60,7 +59,7 @@ func DefaultPredicates(ignoreOperationAnnotation bool) []predicate.Predicate {
// 'garden' namespace and don't belong to a Shoot. Most other DNSRecord resources are created in regular shoot
// namespaces (in such cases we want to check whether the respective Shoot is failed). Consequently, we add both
// preconditions and ensure at least one of them applies.
predicateutils.Or(
predicate.Or(
extensionspredicate.IsInGardenNamespacePredicate,
extensionspredicate.ShootNotFailedPredicate(),
),
Expand Down
77 changes: 0 additions & 77 deletions pkg/controllerutils/predicate/or.go
View file
Open in desktop

This file was deleted.

63 changes: 0 additions & 63 deletions pkg/controllerutils/predicate/or_test.go
View file
Open in desktop

This file was deleted.