Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misMatchThreshold and requireSameDimensions nullish coalescing (#1557) #1558

Merged

Conversation

dgrebb
Copy link
Contributor

@dgrebb dgrebb commented Mar 5, 2024

This fixes #1557, which I introduced when working on #1492. My bad!

…ult `misMatchThreshold` and `requireSameDimensions` values (garris#1557)
@garris garris merged commit d6a3abd into garris:master Mar 5, 2024
1 check passed
@garris
Copy link
Owner

garris commented Mar 5, 2024

Thank you @dgrebb! Will push tomorrow. Cheers!

@dgrebb dgrebb deleted the bugfix/1557-nullish-coalescing-vs-logical-or branch April 30, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requireSameDimensions property is not working
2 participants