Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): improve hot-reloading for hooks #16546

Merged
merged 2 commits into from Aug 12, 2019
Merged

Conversation

theKashey
Copy link
Contributor

Reincarnation of #16146

Description

This is a follow up for #13713(RHL+Hooks), and gaearon/react-hot-loader#1309 (RHL + Gatsby)

The problem: application breaking if node_modules exists in the src dir. There is no question "why", the question is "why".

Fix

In short - there is no need to apply react-hot-loader/webpack for all node_modules, only for react-dom to land the patch, and that's all the change.

  • Plus bump react-hot-loader to fix the problems we found in the previous PR with cyclic dependencies, and make it React 16.9 compatible.

Outcome:

The problem is fixed and everything is a bit faster.

Related Issues

@theKashey theKashey requested a review from a team as a code owner August 12, 2019 11:27
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Really appreciate effort you put into those pesky circular deps! ❤️

@pieh pieh merged commit 8d66161 into gatsbyjs:master Aug 12, 2019
@gatsbot
Copy link

gatsbot bot commented Aug 12, 2019

Holy buckets, @theKashey — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@pieh
Copy link
Contributor

pieh commented Aug 12, 2019

Published gatsby@2.13.60

@sidharthachatterjee
Copy link
Contributor

sidharthachatterjee commented Aug 13, 2019

Thank you so much for your incredible work here @theKashey 💜

@theKashey
Copy link
Contributor Author

You also helped to surface a very nasty issue. So all kudos go for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants