fix(gatsby): improve hot-reloading for hooks #16546
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up for #13713(RHL+Hooks), and gaearon/react-hot-loader#1309 (RHL + Gatsby)
The problem: application breaking if
node_modules
exists in thesrc
dir. There is no question "why", the question is "why".Fix
In short - there is no need to apply
react-hot-loader/webpack
for allnode_modules
, only forreact-dom
to land the patch, and that's all the change.react-hot-loader
to fix the problems we found in the previous PR with cyclic dependencies, and make it React 16.9 compatible.Outcome:
The problem is fixed and everything is a bit faster.
Related Issues
react-hot-loader/webpack