Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): Migrate from source-map to @jridgewell/trace-mapping #35621

Merged
merged 4 commits into from Jun 1, 2022

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented May 10, 2022

Description

Due to nodejs/node#42638 the source-map package is breaking in Node v18. We can migrate to https://github.com/jridgewell/trace-mapping like Jest (jestjs/jest#12692) and Istanbul (istanbuljs/v8-to-istanbul#186) did.

TODOs:

Documentation

No update needed.

Related Issues

Fixes #35607
[ch50439]

@LekoArts LekoArts added the type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change label May 10, 2022
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 10, 2022
@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 10, 2022
@LekoArts LekoArts marked this pull request as ready for review May 31, 2022 11:00
@LekoArts
Copy link
Contributor Author

I still need to do some manual testing with this

@LekoArts
Copy link
Contributor Author

LekoArts commented Jun 1, 2022

Local testing looks good 👍

@LekoArts LekoArts merged commit fc5df03 into master Jun 1, 2022
@LekoArts LekoArts deleted the source-map-migration branch June 1, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

You must provide the URL of lib/mappings.wasm by calling SourceMapConsumer.initialize
3 participants