chore: Run Unit Tests on Node 16 and 18 #35622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: automation
3 tasks
|
The PR is currently failing due to parcel-bundler/parcel#8055 - we use Parcel 2.5.0 which uses a |
pieh
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should run on more than Node 14.15.0 as we'll move to >=16 later this year anyways. And we recently had some issues with Node 18, so we should also run tests again that.
This PR also improves the error message for Parcel (adding the original message) that was uncovered by swallowed errors in CI when lmdb didn't have the node 18 binaries.
Also mocking
trackErrorin tests so that it doesn't fail on that either (as a red herring).Unblocks: #35621
[ch50968]