Remove test references to old CI #5615
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test has been broken for a while, but we hadn't noticed because of an unexpected way of skipping the test for TravisCI, which we no longer use. In TravisCI, the `TRAVIS` environment variable is set to 1. However, in other environments, it is usually not set. As a consequence, it expands to the empty string. The `if` statement in sh is not the `if` statement in C, and thus it does not take a boolean value, and "1" would not be a valid value here. The empty string is a valid value, though, and it is interpreted as a no-op command, much like `:` or `true`, which are the customary ways to write this. Because this command always succeeds, we always skip this branch, and the body of the test is not executed. After removing this, our test fails because `assert_clean_status` is not run in a Git repository. We clearly wanted to run it in `$newclonedir`, so let's do that. In addition, the text "Git LFS:" is no longer printed, so don't look for it. With those changes, this test now passes.
We no longer use Appveyor or TravisCI, so let's remove references to them in the testsuite.
bk2204
force-pushed
the
bye-bye-old-ci
branch
from
9bedb51
to
5302960
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer use Appveyor or TravisCI, so let's remove references to them in the testsuite.