plumbing/transport/ssh: do not override HostKeyCallback if set #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the custom Auth method that returns `ClientConfig` with custom `HostKeyCallback` to check a host against known fingerprints (kind of white list), but the `SetConfigHostKeyFields` function always overrides the `HostKeyCallback` to read the fingerprints from the files and etc... Added a simple check fixes the issue by calling the `SetConfigHostKeyFields` only if the `HostKeyCallback` is `nil`.
|
Can you maybe extend the tests in |
|
Duplicate of #655. |
|
cool, then I close this in favor of #655, that implementation looks better than mine, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the custom Auth method that returns
ClientConfigwith customHostKeyCallbackto check a host against known fingerprints (kind of white list), but theSetConfigHostKeyFieldsfunction always overrides theHostKeyCallbackto read the fingerprints from the files and etc...Added a simple check fixes the issue by calling the
SetConfigHostKeyFieldsonly if theHostKeyCallbackisnil.