Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plumbing/transport/ssh: do not override HostKeyCallback if set #698

Closed
wants to merge 1 commit into from
Closed

plumbing/transport/ssh: do not override HostKeyCallback if set #698

wants to merge 1 commit into from

Commits on Mar 3, 2023

  1. plumbing/transport/ssh: do not override HostKeyCallback if set 

    We use the custom Auth method that returns `ClientConfig` with custom `HostKeyCallback` to check a host against known fingerprints (kind of white list),
but the `SetConfigHostKeyFields` function always overrides the `HostKeyCallback` to read the fingerprints from the files and etc...

Added a simple check fixes the issue by calling the `SetConfigHostKeyFields` only if the `HostKeyCallback` is `nil`.
    @SVilgelm
    SVilgelm committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    a20be31 View commit details
    Browse the repository at this point in the history