Remove If Exist check on migration for mssql because that syntax required SQL server 2016 #30894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ired SQL server 2016
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
github-actions
bot
added
modifies/go
wxiaoguang
approved these changes
May 8, 2024
GiteaBot
added
lgtm/need 1
|
Can we catch the error when index not existing, then only show a warning, and return no error? |
CI failure is unrelated. It's an actions/setup-go upgrade problem. I think it's hard to catch the error of MSSQL for different versions. And it should be right, otherwise it means Gitea's database has been broken in previous migrations or situations. |
|
I think we should raise the MSSQL requirement to 2016 for v1.23, e.g. follow the "Security Support" category of https://endoflife.date/mssqlserver. |
|
https://github.com/go-gitea/gitea/actions/runs/8996206824/job/24712337648#step:8:142 |
…a into lunny/fix_migration_sqlserver
pull-request-size
bot
added
size/S
yp05327
approved these changes
May 11, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
May 11, 2024
…ired SQL server 2016 (go-gitea#30894) Fix go-gitea#30872 We will assume the database is consistent before executing the migration. So the indexes should exist. Removing `IF EXIST` then is safe enough. --------- Co-authored-by: silverwind <me@silverwind.io>
GiteaBot
added
backport/done
#30949 to raise the requirement to 2017. |
lunny
added a commit
that referenced
this pull request
May 12, 2024
…ired SQL server 2016 (#30894) (#30946) Backport #30894 by @lunny Fix #30872 We will assume the database is consistent before executing the migration. So the indexes should exist. Removing `IF EXIST` then is safe enough. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: silverwind <me@silverwind.io>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 13, 2024
* giteaofficial/main: [skip ci] Updated licenses and gitignores Fix file path width in repo non-homepage view (go-gitea#30951) Enable `declaration-block-no-redundant-longhand-properties` (go-gitea#30950) [skip ci] Updated translations via Crowdin Move reverproxyauth before session so the header will not be ignored even if user has login (go-gitea#27821) Use CSS `inset` shorthand (go-gitea#30939) Remove If Exist check on migration for mssql because that syntax required SQL server 2016 (go-gitea#30894) Update JS dependencies, add new eslint rules (go-gitea#30840) Fix some UI regressions for commit list (go-gitea#30920) Forbid deprecated `break-word` in CSS (go-gitea#30934) Check if reverse proxy is correctly configured (go-gitea#30890) Remove deprecated stuff for runners (go-gitea#30930)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30872
We will assume the database is consistent before executing the migration. So the indexes should exist. Removing
IF EXISTthen is safe enough.