Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove If Exist check on migration for mssql because that syntax required SQL server 2016 #30894

Merged
merged 8 commits into from
May 11, 2024
Merged

Remove If Exist check on migration for mssql because that syntax required SQL server 2016 #30894

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4fe2ff6
Remove If Exist check on migration for mssql because that syntax requ…
lunny May 8, 2024
45fe757
Merge branch 'main' into lunny/fix_migration_sqlserver
silverwind May 8, 2024
e53467c
Fix bug
lunny May 10, 2024
57ea530
Merge branch 'main' into lunny/fix_migration_sqlserver
lunny May 10, 2024
94e48c4
Merge branch 'lunny/fix_migration_sqlserver' of github.com:lunny/gite…
lunny May 10, 2024
05c9553
Fix test
lunny May 10, 2024
8a8e510
Fix test
lunny May 10, 2024
909c262
Merge branch 'main' into lunny/fix_migration_sqlserver
GiteaBot May 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions models/migrations/v1_22/v286.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ func expandHashReferencesToSha256(x *xorm.Engine) error {
if setting.Database.Type.IsMSSQL() {
// drop indexes that need to be re-created afterwards
droppedIndexes := []string{
"DROP INDEX IF EXISTS [IDX_commit_status_context_hash] ON [commit_status]",
"DROP INDEX IF EXISTS [UQE_review_state_pull_commit_user] ON [review_state]",
"DROP INDEX IF EXISTS [UQE_repo_archiver_s] ON [repo_archiver]",
"DROP INDEX [IDX_commit_status_context_hash] ON [commit_status]",
"DROP INDEX [UQE_review_state_pull_commit_user] ON [review_state]",
"DROP INDEX [UQE_repo_archiver_s] ON [repo_archiver]",
}
for _, s := range droppedIndexes {
_, err := db.Exec(s)
Expand Down