-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rate limiter to client #494
Conversation
60ee7ca
to
9f72f7c
Compare
@jeevatkm Could you please check this? it would be great to have integrated rate limiter |
So it looks ok, what needs to be done to finish this? I can help. |
c28157d
to
ee59148
Compare
@dbriemann I'm sorry for the delayed attention on the PR. Your feature proposal make sense, do you mind preparing the PR for review with tests & validation build success? |
I am very busy these days but I can have a look in the near future what exactly there is left to do. |
@dbriemann Thanks for getting back. |
OK I found some time to update this today. It is a very simple rate limiter which returns an Not sure how good the API is. Just give it a review. |
@dbriemann My apologies for the late. I have thought about it. Adding an interface contract into Resty will provide options for the users to any rate limiter or their version instead of integrating the library In this PR, you have used the Are you interested in taking it up? Please let me know. |
has been merged in #715, can be closed |
Of-course @SVilgelm |
Add a simple per client rate limiting based on
golang.org/x/time/rate
.