Add rate limiter to client #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm unable to push directly to @dbriemann's PR, so had to create this one. |
SVilgelm
force-pushed
the
feature/rate_limiting
branch
from
8c264e1
to
d8914b2
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #715 +/- ##
==========================================
+ Coverage 96.33% 96.34% +0.01%
==========================================
Files 12 12
Lines 1610 1616 +6
==========================================
+ Hits 1551 1557 +6
Misses 37 37
Partials 22 22
☔ View full report in Codecov by Sentry. |
jeevatkm
approved these changes
Sep 30, 2023
There was a problem hiding this comment.
Thank you @SVilgelm @dbriemann for your contribution 👍 appreciated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple per client rate limiting based on
Allow() boolinterfaceContinue work on #494