Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sync pool data race: deep copy #635

Merged

Conversation

zhongdalu-trechina
Copy link
Contributor

@zhongdalu-trechina zhongdalu-trechina commented Mar 21, 2023

fixes #630

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #635 (5d5fd98) into master (9943eab) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #635   +/-   ##
=======================================
  Coverage   95.82%   95.83%           
=======================================
  Files          11       11           
  Lines        1557     1560    +3     
=======================================
+ Hits         1492     1495    +3     
  Misses         40       40           
  Partials       25       25           
Impacted Files Coverage Δ
middleware.go 90.68% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhongdalu-trechina Thanks for your PR.

@jeevatkm jeevatkm merged commit b34a3ad into go-resty:master Mar 21, 2023
5 checks passed
@tanvir-retailai
Copy link

@jeevatkm any plan to release v2.8.0 soon?

@bertold
Copy link

bertold commented Jun 15, 2023

@jeevatkm - still no release since November 2021. Are you looking for contributors to help? I would prefer not to fork, but this issue is forcing me to either fork or abandon resty altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

DATA RACE: between go-resty/resty/v2.releaseBuffer() and h2_bundle body
4 participants