fix: fixes path issues on windows

[Monirzadeh]

This PR try to fix failed test in windows and fix #822
TODO:

• thumb path fix
• serve frontend files in windows and pass style css test in frontpage_test.go for windows.
• failed to create destination dir file does not exist.
  • everywhere we us WriteFile this test failed in windows. core test failed because of that.
  • maybe this is a false negative. i can pass that with some change and manual testing work fine in windows too. i should be sure about that. (pass a not absolute path for temp in unit test and it work fine)
    for example change this two line
    

    shiori/internal/core/ebook_test.go

    Lines 25 to 26 in 84e5b09

    	tempDir := t.TempDir()
    	dstDir := t.TempDir()

    
    to this and test will pass
• The process cannot access the file because it is being used by another process.
  • it happen in golang 1.20 for record testing: TempDir RemoveAll cleanup failures with "The process cannot access the file because it is being used by another process." golang/go#51442 and review later
  • TestReadDotEnv everywhere we use os.RemoveAll

tempDir := "tmpdir"
dstDir := "dstdir"

• cleanup the code and unify variable names

Fixes #829
Fixes #824
Fixes #823
Close #827
Close #822

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (15b2a1e) 25.49% compared to head (ffe6f26) 25.49%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #829   +/-   ##
=======================================
  Coverage   25.49%   25.49%           
=======================================
  Files          47       47           
  Lines        5632     5632           
=======================================
  Hits         1436     1436           
+ Misses       3999     3997    -2     
- Partials      197      199    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fmartingr]

Try this changes to the database tests:
dbtest.patch

[fmartingr]

Could be a permissions issue on Windows maybe?

[Monirzadeh]

Could be a permissions issue on Windows maybe?

maybe but i am not sure how should solve that
i think something wrong with TempDir itself.
lots of same error report for TempDir in golang repository. you can just search error in golang.

The process cannot access the file because it is being used by another process.

[Monirzadeh]

i manualy create directory in C:\Users\myusesrname\AppData\Local\Temp\ name test
and pass path to test and, .env created in there and test pass.
is should check how can i should change permission for t.TempDir()

Update

			tmpDir := t.TempDir()
			os.Chmod(tmpDir, 0777)
			os.Chdir(tmpDir)

not work :(

[fmartingr]

Thanks for researching into this, I've left a few comments around, mostly around path generation (we should use filepath.Join or path.Join where appropiate), and to remove some other temporary things.

[Monirzadeh]

i think everything's work fine now.

Note: i am not sure that env is in correct location.

[fmartingr]

I have pushed a commit to your branch with the env change.

Can you check the test change for these lines: https://app.codecov.io/gh/go-shiori/shiori/pull/829/indirect-changes#79a7897873ac5d4fcc5ba2f5c3b3e482-R138

It seems we have stopped testing part of the happy path. I'm not concerned about the if err != nil not being tested, but the if err == nil should be covered be tests, more so if tests were covering those lines before.

[Monirzadeh]

@fmartingr i fix that.
the problem is that serve file from local disk not working correctly in windows in test
ProcessRequest sucssesful with multipleimage included favicon and Thumbnai. for now, i serve them from shiori repository until i can find a solution to fix file server in windows (test some of them but not working in windows yet) and send another PR for that later if it is ok for you.
what do you think?

Update: add one more check to be sure thumbnail exist on disk :)

[fmartingr]

Ok. just the log issue in the test, everything seems ready to go. Again, awesome work, thanks a lot for digging into this in windows :)