Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decode struct with pointer must be nil #473

Merged
merged 1 commit into from Oct 19, 2023
Merged

Conversation

misyuari
Copy link
Contributor

@misyuari misyuari commented Oct 3, 2023

fix #472

@misyuari
Copy link
Contributor Author

any comment? @goccy

@goccy
Copy link
Owner

goccy commented Oct 19, 2023

Thank you for your contribution ! The changes are LGTM 👍
lint job is failing, please merge master once.

@misyuari
Copy link
Contributor Author

Thank you for your contribution ! The changes are LGTM 👍 lint job is failing, please merge master once.

done 🚀

@codecov-commenter
Copy link

Codecov Report

Merging #473 (029656a) into master (3d5ab28) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #473   +/-   ##
=======================================
  Coverage   76.78%   76.78%           
=======================================
  Files          55       55           
  Lines       18921    18922    +1     
=======================================
+ Hits        14528    14529    +1     
  Misses       3759     3759           
  Partials      634      634           

@goccy goccy merged commit df897ae into goccy:master Oct 19, 2023
14 checks passed
@goccy
Copy link
Owner

goccy commented Oct 19, 2023

Thank you !! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

decode struct with pointer field must be nil when error
3 participants