Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin docutils to <0.18 to fix CI due to new warning #5362

Merged
merged 1 commit into from Nov 2, 2021

Conversation

mhilbrunner
Copy link
Member

@mhilbrunner mhilbrunner commented Nov 2, 2021

This pins docutils to versions below 0.18, which should fix the current CI issues in some branches due to the warning node class 'meta' is already registered, its visitors will be overridden (with the CI aborting, as we treat warnings as errors). This is due to an update to docutils, which sphinx is semingly not (yet) compatible with. According to the sphinx Github, there are further incompatabilities besides this warning.
Upstream sphinx also pins the version to <0.18, with work happening recently in the master branch to support docutils>=18.

For reference, see also this docutils issue and this sphinx issue.

We should reconsider this pin when updating sphinx in the future.

@mhilbrunner mhilbrunner added the bug label Nov 2, 2021
@mhilbrunner mhilbrunner merged commit 6da0bea into godotengine:master Nov 2, 2021
@mhilbrunner mhilbrunner deleted the pin-docutils branch November 2, 2021 00:37
@mhilbrunner
Copy link
Member Author

Cherrypicked to 3.4 (14c0aee), 3.3 (29d2abf), 3.2 (fe90ee5) and stable (a3b2611).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant