Skip to content

Commit

Permalink
Revert "gopls/internal/test/integration/misc: reenable staticcheck test"
Browse files Browse the repository at this point in the history
This reverts commit 618670d.

Reason for revert: The test does not in fact pass, but this was obscured by a bug (?) in the godebug machinery, which uses a default value poked into the executable at link-time of "...gotypesalias=0...",
which means the default value is not "on", as we thought when we changed the interpretation of unset to mean "on".

Change-Id: Ib45b230a80d8b52a9d69db56025dae34add29fb8
Reviewed-on: https://go-review.googlesource.com/c/tools/+/579757
Auto-Submit: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
  • Loading branch information
adonovan authored and gopherbot committed Apr 19, 2024
1 parent 618670d commit daf9460
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions gopls/internal/test/integration/misc/staticcheck_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ import (
func TestStaticcheckGenerics(t *testing.T) {
testenv.NeedsGo1Point(t, 20) // staticcheck requires go1.20+

// TODO(golang/go#65249): re-enable and fix this test with gotypesalias=1.
testenv.SkipMaterializedAliases(t, "staticcheck needs updates for materialized aliases")

const files = `
-- go.mod --
module mod.com
Expand Down Expand Up @@ -80,6 +83,9 @@ var FooErr error = errors.New("foo")
func TestStaticcheckRelatedInfo(t *testing.T) {
testenv.NeedsGo1Point(t, 20) // staticcheck is only supported at Go 1.20+

// TODO(golang/go#65249): re-enable and fix this test with gotypesalias=1.
testenv.SkipMaterializedAliases(t, "staticcheck needs updates for materialized aliases")

const files = `
-- go.mod --
module mod.test
Expand Down

0 comments on commit daf9460

Please sign in to comment.