bugfix: #614 #615
Open
bugfix: #614 #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
hjhjw1991
force-pushed
the
bugfix/hjhjw1991/child_wrong_top_margin
branch
from
f2abf61
to
02998fe
Compare
hjhjw1991
force-pushed
the
bugfix/hjhjw1991/child_wrong_top_margin
branch
from
02998fe
to
bde7cfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug: when using FlexboxLayoutManager with flex-direction set to column, a child having top margin will result in an unexpected top margin on every following child
cause: previous child's TOP_MARGIN is added when moving childTop down. I think it should be BOTTOM_MARGIN instead. similar for childBottom