Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RequireCodeOwnerReviews and RequiredApprovingReviewCount fields with omitempty #2289

Merged
merged 4 commits into from Feb 14, 2022

Conversation

leopoldwang
Copy link
Contributor

@leopoldwang leopoldwang commented Feb 11, 2022

Fixes: #2286.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @leopoldwang !
Please run go generate ./... and push (not force-push) the changes to this PR.
See CONTRIBUTING.md for more details.

github/repos.go Show resolved Hide resolved
@gmlewis gmlewis changed the title Fix #2286 Fix RequireCodeOwnerReviews and RequiredApprovingReviewCount fields with omitempty Feb 12, 2022
@codecov
Copy link

codecov bot commented Feb 12, 2022

Codecov Report

Merging #2289 (d11e2fd) into master (2be8000) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2289   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files         115      115           
  Lines       10360    10360           
=======================================
  Hits        10136    10136           
  Misses        156      156           
  Partials       68       68           
Impacted Files Coverage Δ
github/repos.go 98.70% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be8000...d11e2fd. Read the comment docs.

github/repos.go Outdated Show resolved Hide resolved
github/repos.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @leopoldwang !
One tiny nit, but otherwise LGTM.

Awaiting second LGTM/Approval from any other contributor to this repo.

@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Feb 13, 2022
Added missing period.

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Awaiting second LGTM/Approval from any other contributor to this repo.

@raynigon
Copy link
Contributor

LGTM.

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 14, 2022

Thank you, @raynigon !
Merging.

@gmlewis gmlewis merged commit 6964b1c into google:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RequireCodeOwnerReviews cannot be set to false when updating
3 participants