-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add create repository with an initial commit with empty README #2333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
Codecov Report
@@ Coverage Diff @@
## master #2333 +/- ##
=======================================
Coverage 98.04% 98.04%
=======================================
Files 118 118
Lines 10458 10458
=======================================
Hits 10254 10254
Misses 140 140
Partials 64 64 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @yuseferi .
Instead of adding a new example that is almost identical to the newrepo
example but with a new flag, please just edit the other example to add your new flag.
sure. just updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you just need to run gofmt
on the modified file, and we should be ready to merge.
gofmt and govet are not handled by golangci-lint, which runs in a separate actions workflow. No need to run them here as well.
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @yuseferi !
LGTM.
Merging.
No description provided.