Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Linkage Checker to examine linkage error at artifact level #1032

Merged
merged 10 commits into from May 26, 2020
12 changes: 8 additions & 4 deletions build.gradle
Expand Up @@ -347,10 +347,14 @@ subprojects {
dependsOn project.getTasksByName('publishMavenJavaPublicationToMavenLocal', true)
classpath = configurations.linkageChecker
main = 'com.google.cloud.tools.opensource.classpath.LinkageCheckerMain'
args '-a', "com.google.api:${project.name}:${project.version}",
'--exclusion-file', 'linkage-checker-exclusion.xml'
// The exclusion file above can be regenerated by '-o' option. See its Wiki for details:
// https://github.com/GoogleCloudPlatform/cloud-opensource-java/wiki/LinkageCheckerMain#exclusion-files

def arguments = ['-a', "com.google.api:${project.name}:${project.version}"]
if (project.name == 'gax-grpc') {
// The exclusion file can be regenerated by '-o' option. See its Wiki for details:
// https://github.com/GoogleCloudPlatform/cloud-opensource-java/wiki/LinkageCheckerMain#exclusion-files
arguments += ['--exclusion-file', 'linkage-checker-exclusion.xml']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me wonder if we really need to set the name and have a command line argument at all. Does it make sense to have a standard filename and location where the linkage checker looks?

}
args arguments
}
}

Expand Down
2 changes: 0 additions & 2 deletions gax-httpjson/linkage-checker-exclusion.xml

This file was deleted.

2 changes: 0 additions & 2 deletions gax/linkage-checker-exclusion.xml

This file was deleted.