Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proof-of-concept for migrating to native
fetch
. However, there are a few limitations today.No native
proxy
supportIt is possible to enable proxy support, however customers would have to install
unidici
downstream. Including it in this library would make it far too large. Here are some numbers:gaxios
undici
@google-cloud/storage
Adding
undici
would double the size of a downstream dependency like@google-cloud/storage
.However, there is discussion on adding the
ProxyAgent
within Node:Workaround
Potential workaround/fallback for customers:
Environment support
Additionally, it wasn't until recently that
undici
added env support forHTTP_PROXY
,HTTPS_PROXY
, &NO_PROXY
and it will take time for it to propagate to Node.js releases:Performance
The native
fetch
implementation is 26% - 28% slower thannode-fetch
according toundici
's benchmarks:node-fetch
Returning Streams
Native
fetch
returns a ReadableStream ('Web Streams') instead ofstream.Readable
. This may require a rewriting downstream for many applications that currently expects a Node stream.However, here's a simple way to resolve:
Additional Notes
https://nodejs.org/en/about/previous-releases
🦕