Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: using full package names to avoid incorrect import merge #1193

Merged
merged 15 commits into from Apr 7, 2023

Conversation

TimurSadykov
Copy link
Member

@TimurSadykov TimurSadykov commented Apr 4, 2023

Adding full package names for ExternalAccountCredentials to avoid imports mix-up due to nested classes.

Long term fix would be to move out nested classes along with next major release. Issue: #1195

@TimurSadykov TimurSadykov requested a review from a team as a code owner April 4, 2023 23:54
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 4, 2023
@product-auto-label product-auto-label bot added size: u Pull request is empty. and removed size: xs Pull request size is extra small. labels Apr 4, 2023
@TimurSadykov TimurSadykov requested a review from a team as a code owner April 5, 2023 22:42
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: u Pull request is empty. labels Apr 5, 2023
@TimurSadykov TimurSadykov changed the title fix: moving import to fix bogus build issue fix: using full package names to fix bogus build issue Apr 7, 2023
@TimurSadykov TimurSadykov changed the title fix: using full package names to fix bogus build issue fix: using full package names to avoid incorrect import merge Apr 7, 2023
@TimurSadykov TimurSadykov changed the title fix: using full package names to avoid incorrect import merge chore: using full package names to avoid incorrect import merge Apr 7, 2023
@arithmetic1728 arithmetic1728 merged commit c52ecaf into main Apr 7, 2023
14 checks passed
@arithmetic1728 arithmetic1728 deleted the stim-imports branch April 7, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants