Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vertexai): passthrough user opts #9163

Merged
merged 2 commits into from Dec 13, 2023
Merged

fix(vertexai): passthrough user opts #9163

merged 2 commits into from Dec 13, 2023

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Dec 13, 2023

Fixes: #9160

@codyoss codyoss requested review from a team as code owners December 13, 2023 21:15
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Dec 13, 2023
@codyoss codyoss added automerge Merge the pull request once unit tests and other checks pass. and removed size: xs Pull request size is extra small. labels Dec 13, 2023
eliben
eliben approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@eliben eliben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, seems like we raced with a fix :-)

Thanks, Cody. I'll drop the other one

@eliben eliben mentioned this pull request Dec 13, 2023
Closed
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Dec 13, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit c24e93c into googleapis:main Dec 13, 2023
9 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 13, 2023
@release-please release-please bot mentioned this pull request Dec 13, 2023
Merged
@codyoss codyoss deleted the fix-opts branch December 13, 2023 21:36
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 13, 2023
@release-please
chore(main): release vertexai 0.5.1 (#9166)
de2d1e0 
🤖 I have created a release *beep* *boop*
---


## [0.5.1](https://togithub.com/googleapis/google-cloud-go/compare/vertexai/v0.5.0...vertexai/v0.5.1) (2023-12-13)


### Bug Fixes

* **vertexai:** Passthrough user opts ([#9163](https://togithub.com/googleapis/google-cloud-go/issues/9163)) ([c24e93c](https://togithub.com/googleapis/google-cloud-go/commit/c24e93c06851d3917d75a9b2362af993071961c0)), refs [#9160](https://togithub.com/googleapis/google-cloud-go/issues/9160)

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliben eliben eliben approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

genai: func NewClient does not use opts ...option.ClientOption param
2 participants
@codyoss @eliben