fix: aggregate batching throttling latency per attempt and reset it between #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etween This should improve reporting of latency when bulk mutation throttling is enabled. Also: - fix tests to properly close the batcher - simplify tests to avoid unnecessary mocking - improve test failure messaging Change-Id: I53748c5e54ebbbe2a896f8ea0ce6c39a8f5fa297
product-auto-label
bot
added
size: m
kolea2
reviewed
Sep 11, 2023
...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/MetricsTracer.java
Show resolved
Hide resolved
kolea2
reviewed
Sep 11, 2023
...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/MetricsTracer.java
Show resolved
Hide resolved
kolea2
approved these changes
Sep 11, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
🤖 I have created a release *beep* *boop* --- ## [2.27.1](https://togithub.com/googleapis/java-bigtable/compare/v2.27.0...v2.27.1) (2023-09-12) ### Bug Fixes * Aggregate batching throttling latency per attempt and reset it between ([#1905](https://togithub.com/googleapis/java-bigtable/issues/1905)) ([e6cc5f6](https://togithub.com/googleapis/java-bigtable/commit/e6cc5f615630d15b717df1056ceed98f21f2297b)) * Make sure to propagate the response when throttling is enabled ([#1908](https://togithub.com/googleapis/java-bigtable/issues/1908)) ([f743187](https://togithub.com/googleapis/java-bigtable/commit/f7431871ba4ea64351fc5710089f8308e91d7978)) ### Dependencies * Update the Java code generator (gapic-generator-java) to 2.25.0 ([#1902](https://togithub.com/googleapis/java-bigtable/issues/1902)) ([f4fe6a0](https://togithub.com/googleapis/java-bigtable/commit/f4fe6a054194f68da1d7a548dec7a1cec68c1a2c)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve reporting of latency when bulk mutation throttling is enabled. Also:
Change-Id: I53748c5e54ebbbe2a896f8ea0ce6c39a8f5fa297
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.